Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak temporal inputs #16472

Merged
merged 2 commits into from
May 14, 2015
Merged

Tweak temporal inputs #16472

merged 2 commits into from
May 14, 2015

Conversation

mdo
Copy link
Member

@mdo mdo commented May 14, 2015

Fixes #16346.

Scopes the overrides for temporal inputs to our input classes rather than all inputs. Also accounts for week inputs.

/cc @cvrebert

@mdo mdo added the css label May 14, 2015
@cvrebert cvrebert added this to the v3.3.5 milestone May 14, 2015
@cvrebert
Copy link
Collaborator

type="week" was supposedly unnecessary as of the version of iOS when the bug was reported to us: #13099 (comment)
Have you re-tested and gotten different results on the latest iOS?

@patrickhlauke
Copy link
Member

iOS8.3 does not support datetime and week, FWIW

@mdo
Copy link
Member Author

mdo commented May 14, 2015

You're right, week doesn't even render as a text field as a fallback in iOS. I removed that at least and tied the remaining ones from our current version to the .form-control class. Should be enough now.

mdo added a commit that referenced this pull request May 14, 2015
@mdo mdo merged commit b6e6a05 into master May 14, 2015
@mdo mdo deleted the fixes_16346 branch May 14, 2015 17:43
@cvrebert cvrebert mentioned this pull request May 14, 2015
@cvrebert
Copy link
Collaborator

😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Height of plain <input type="week"> doesn't match height of other temporal <input>s in Chrome
3 participants