Customizable grid gutters per breakpoint #17481
Conversation
| @@ -119,6 +118,13 @@ $container-max-widths: ( | |||
| $grid-columns: 12 !default; | |||
| $grid-gutter-width: 1.875rem !default; // 30px | |||
There was a problem hiding this comment.
Confusing indeed, this one should be removed.
|
that's awesome! @pixelbandito |
|
This is now pretty out of date. Holler if you feel like taking a fresh pass after #19099 is merged <3. |
|
@pixelbandito Do you still intend to get this merged? It's mad out of date, but I'd love to see this feature available... |
|
This would be super dope to get into Alpha 5. Any help on getting this rebased and up to speed would be amazing! |
|
I'm awake! I'll pick this back up. Thanks for the encouragement, folks. |
pixelbandito
force-pushed
the
customizable-grid-gutters-per-breakpoint
branch
from
147b070 to
d211810
Compare
| @each $breakpoint in map-keys($gutters) { | ||
| @include media-breakpoint-up($breakpoint) { | ||
| $gutter: map-get($gutters, $breakpoint); | ||
| margin-left: ($gutter / -2); |
There was a problem hiding this comment.
Properties should be ordered margin-right, margin-left
pixelbandito
force-pushed
the
customizable-grid-gutters-per-breakpoint
branch
6 times, most recently
from
f81c1d3 to
074f559
Compare
|
@mdo Rebased and up to speed. |
pixelbandito
force-pushed
the
customizable-grid-gutters-per-breakpoint
branch
from
074f559 to
0ef64d8
Compare
|
Thanks so much! |
|
@pixelbandito Any chance you have time to do a follow up to this PR that implements the same flexibility to the containers? If not I can try to swing back around to it soon :). |
|
Hey @pixelbandito & @mdo, the ability to define a customizable grid gutters width per breakpoint has been remove from the brand new V4, right? If so, this would be very useful to put it back. |
As per #17021 (which references #11873), this change adds a $grid-gutters-widths array in _variables.scss, and then uses the array in the grid framework instead of a single gutter width.
Possible concern: The old $grid-gutter-width was used several places, so I left it in; but that might cause confusion.