-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexbox grid column wrapping bug #17756
Conversation
@@ -46,6 +46,7 @@ | |||
@mixin make-col-span($size, $columns: $grid-columns) { | |||
@if $enable-flex { | |||
flex: 0 0 percentage($size / $columns); | |||
max-width: percentage($size / $columns); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the bug doesn't occur in other browsers, this line should have an // IE10+
comment to note why it's necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without setting max-width
this bug occurs in Firefox too.
Yes, it's a flexbox grid column bug.
|
Notice the issues happens not only on the grids, but also before the breakpoints. Your html can look like:
Now the following CSS code should fix the issue:
The above do not fix the issue for screens smaller than 544px;. So to fix for smaller screens too the compile code for the
Example can also be found here: https://github.com/bassjobsen/bootstrap/blob/patch-32/docs/examples/dashboard/dashboard.css#L143 The Finally notice that alternative fix:
|
Problem doesn't impact Safari or Chrome, at least on Mac. Confirmed that this fixed it in Firefox Mac though, so merged. Comment added in dfae3d4. |
I also had to use a |
With flexbox enabled, please take a look at this in
IE10+all browsers:This is what i get: