Ensure transition effect displays on modals with remote content #18272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @joshreed! Thanks for wanting to contribute to Bootstrap by sending this pull request! You'll need to fix these mistakes and revise your pull request before we can proceed further. (Please note that this is a fully automated comment.) |
|
Tests failed. Automated cross-browser testing via Sauce Labs and Travis CI shows that the JavaScript changes in this pull request are: BUSTED Commit: 2933ebd (Please note that this is a fully automated comment.) |
|
Successor: #18274 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, remote content, unless loaded really quickly, or already cached in-browser, will not always show the (CSS) transitions, which is a nuisance.
This change makes it so that the "in" class is not added to the modal until loaded even is triggered (if applicable). This seems to work well, though if there are suggestions on a better/preferred alternative implementation, I'm certainly flexible.
Additionally, I did not add any Unit tests, because I didn't see any examples of how you would be handling remote/ajax requests in your tests? This change will only be applicable in situations where the "remote" option is set. I am assuming the best way would be to "mock" the request; if you have any suggestions, I would be happy to add test cases. All existing tests still passed when I ran the suite.