Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button order #183

Closed
wants to merge 1 commit into from
Closed

Fix button order #183

wants to merge 1 commit into from

Conversation

nikku
Copy link

@nikku nikku commented Sep 9, 2011

Fix for issue #181.

@mdo
Copy link
Member

mdo commented Sep 9, 2011

Please recompile the LESS files whenever you do a pull request :).

@nikku
Copy link
Author

nikku commented Sep 9, 2011

Won't work at the moment, am using windows :o)

@mdo
Copy link
Member

mdo commented Sep 9, 2011

Gotcha. I can just manually added this change over then. Thanks!

The only nuance to this however is that any secondary buttons must come first given the new style. You're aware of that change, yes?

@vreon
Copy link

vreon commented Sep 9, 2011

Hmm, I have to say I prefer the current behavior, with the primary button being rightmost and first in the tab order. It seems that different OSes have different conventions regarding this.

@mdo
Copy link
Member

mdo commented Sep 12, 2011

Yup, going to leave them as is with floats. This way, if styles are turned off or if you wish to change them as a developer, the markup does not need to change. The primary button should come first in the markup and the CSS should change the order if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants