v4: Grid adjustments #20865
Merged
v4: Grid adjustments #20865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it so that the container is no longer wider than the breakpoint used in the media query. This was never really an issue in rendering as the max-width handled it appropriately, but the mismatch was still incorrect. Fixes #18054
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grouping a handful of CSS and docs changes related to the grid:
max-widthcontainers towidth, with amax-width: 100%. This corrects inconsistencies between browsers and default/flexbox grid implementations; previously some containers wouldn't occupy their fullmax-width. Fixes Inconsistent cross-browser behavior for .container #20681.smbreakpoint and container. Now the breakpoint is wider than the container (this was a longstanding bug from me, sorry about that 😁). Fixes sm container width is larger than minimum sm viewport width #18054.940pxto960pxso that every grid tier, in it's max width, is cleanly divisible by 12. Fixes Not all .container widths are divisible by 12 #18510.