Dropdown. Skip element disabled via attribute when using keyboard navigation #25403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsn4ik
commented
Jan 22, 2018
| done() | ||
| }) | ||
| $dropdown.trigger('click') | ||
| }) | ||
|
|
||
| QUnit.test('should focus next/previous element when using keyboard navigation', function (assert) { |
There was a problem hiding this comment.
Changed order of tests
|
Nice |
|
@mdo Will it be added to the next release? |
|
Please @vsn4ik can you update your branch ? I'll try to review that asap 😉 |
|
@Johann-S Done! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://getbootstrap.com/docs/4.0/components/dropdowns/#menu-items