add code coverage #25760
add code coverage #25760
Conversation
package.json
Outdated
| @@ -39,6 +39,7 @@ | |||
| "js-compile-standalone": "rollup --environment BUNDLE:false --config build/rollup.config.js --sourcemap", | |||
| "js-compile-bundle": "rollup --environment BUNDLE:true --config build/rollup.config.js --sourcemap", | |||
| "js-compile-plugins": "cross-env PLUGINS=true babel js/src/ --out-dir js/dist/ --source-maps", | |||
| "js-compile-plugins-coverage": "cross-env PLUGINS=true NODE_ENV=test babel js/src/ --out-dir js/dist/coverage/ --source-maps", | |||
There was a problem hiding this comment.
maybe I should change the output dir to : js/coverage/dist which is not distributed through npm 🤔
Johann-S
force-pushed
the
v4-dev-johann-coverage
branch
from
efd4c23 to
b5f5719
Compare
|
it's give us something like this in
|
|
Shouldn't we have a service like Travis so that we can check quickly things? I'm pretty sure there are various services we could integrate. |
|
Travis execute it for us see : https://travis-ci.org/twbs/bootstrap/jobs/348736259#L704 |
|
OK, I'm just used to coverage as a repo hook. But this works too. |
|
I thinks it's a good first step and it's pretty convenient to be able to run the coverage locally , but I'm not against a hook in an other PR |
Johann-S
force-pushed
the
v4-dev-johann-coverage
branch
from
b5f5719 to
20f0d91
Compare
|
Would you like that PR @XhmikosR ? Or do you have any concerns ? If not maybe can you approve my PR 😄 |
|
@Johann-S; just make sure you resolve the conflicts properly :) |
Johann-S
force-pushed
the
v4-dev-johann-coverage
branch
from
fb8d7a8 to
9add2bc
Compare
We this PR we will be sure our JS is covered at 80% but we are free to grow this percentage 😉
BTW it should throw an error if we move under 80% of covered code
Fixes : #25748
/CC @XhmikosR, @bardiharborow