Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get the transition duration parent #25834

Merged
merged 1 commit into from
Mar 13, 2018

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Mar 13, 2018

@Johann-S Johann-S requested a review from XhmikosR March 13, 2018 09:40
@Johann-S Johann-S force-pushed the v4-johann-fix-transition-duration-parent branch from 426b3da to dd1a201 Compare March 13, 2018 09:49
@MartijnCuppens
Copy link
Member

Why would you get the transition duration from the parent if the element has no transition duration?

@Johann-S
Copy link
Member Author

Johann-S commented Mar 13, 2018

Because as I linked, you cannot get the inherited transition duration on Safari, and in Bootstrap sometimes we use Util.getTransitionDurationFromElement with a child element which do not contain any transition duration

EDIT:
Finally I was wrong we have no use case where we get the transition from the parent so I'll remove a bit of my code

@Johann-S Johann-S force-pushed the v4-johann-fix-transition-duration-parent branch from dd1a201 to dfdbd76 Compare March 13, 2018 10:26
@Johann-S Johann-S merged commit 2c41b0a into v4-dev Mar 13, 2018
@Johann-S Johann-S deleted the v4-johann-fix-transition-duration-parent branch March 13, 2018 11:57
@mdo mdo mentioned this pull request Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants