Update dependencies. #25840
Update dependencies. #25840
Conversation
XhmikosR
force-pushed
the
v4-dev-xmr-update-deps
branch
from
effb4ac to
e35d4db
Compare
|
There are a new release of Popper.js (released yesterday): 1.14.1 |
package.json
Outdated
| "shelljs": "^0.8.1", | ||
| "shx": "^0.2.2", | ||
| "sinon": "^4.4.3", | ||
| "sinon": "^4.4.5", |
There was a problem hiding this comment.
should we upgrade to their new major release Sinon 5 ? Because currently we haven't unit tests which use Sinon (but it'll happen soon)
Hmm no finally Sinon 5 isn't ready
Yeah, but it doesn't have any changes to the dist files as far as I can tell. As for sinon, I wasn't sure if v5 works so I stayed with v4 to be safe. |
|
We cannot update to QUnit 2.5.1 because of |
js/tests/index.html
Outdated
| @@ -26,7 +26,7 @@ | |||
| <script src="https://code.jquery.com/qunit/qunit-2.4.1.js"></script> | |||
|
|
|||
| <!-- Sinon --> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/sinon.js/4.4.3/sinon-no-sourcemaps.min.js"></script> | |||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/sinon.js/4.4.5/sinon-no-sourcemaps.min.js"></script> | |||
There was a problem hiding this comment.
It's 404 that is why I haven't changed it. Please revert it.
Johann-S
force-pushed
the
v4-dev-xmr-update-deps
branch
from
670b9ff to
eb001da
Compare
|
@XhmikosR I can make a commit this week? |
|
@Lyricalz: sure thing, just CC me! |
|
Finally karma-runner/karma-qunit#98 is merged, so we'll have to wait for their next release 👍 |
|
I updated karma-qunit on my local branch and it doesn't work... So currently I don't understand where it failed in our karma plugins... Or if it's Karma itself |
|
Made a PR for workbox here: #25873 |
XhmikosR
force-pushed
the
v4-dev-xmr-update-deps
branch
from
a3ff86f to
df47127
Compare
|
@Johann-S: it seems we are hitting https://github.com/rollup/rollup/wiki/Troubleshooting#name-is-not-exported-by-module I also updated I think after we fix this new error, only the CDN switch is left along with updating qunit in tests. |
|
I don't think it's related to Rollup or Babel Plugins helpers but more related to : Maybe |
|
I fixed the previous error but they are another one 😢 Edit: |
|
I guess I will revert that but it would be nice if we could pinpoint the
cause and report it or fix it.
…On Tue, Mar 20, 2018, 23:47 Johann-S ***@***.***> wrote:
If I set qunitjs to 2.4.1 and karma-qunit to 1.2.1 everything works...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25840 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtajArJ4-xcud1lMubt6kS4i30Sflks5tgXkAgaJpZM4SpGU5>
.
|
|
I checked a lot karma-qunit and for me it's more related to a change in QUnit which should be handled in karma-qunit |
|
I'll try downgrading karma-qunit tomorrow, unless you beat me to it. |
Kept back karma-qunit and qunitjs because tests fail.
|
I downgraded karma-qunit and qunitjs and tests work again. |
XhmikosR
force-pushed
the
v4-dev-xmr-update-deps
branch
from
1a67a9f to
2a59bab
Compare
This reduces duplication and the chances to forget to update something.
XhmikosR
force-pushed
the
v4-dev-xmr-update-deps
branch
from
9919b4c to
702fcb3
Compare
I left workbox-build @2.1.3 since I can't find any docs what they have changed and with v3.0.0 it's broken.
Maybe @Lyricalz can help us out :)
TODO: