Use transitionEnd in QUnit since we moved away from PhantomJS #25896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
force-pushed
the
v4-johann-qunit-transition
branch
from
6adaf8a to
51fe56f
Compare
XhmikosR
reviewed
Mar 20, 2018
js/src/util.js
Outdated
| @@ -14,7 +14,9 @@ const Util = (($) => { | |||
| * ------------------------------------------------------------------------ | |||
| */ | |||
|
|
|||
| let transition = false | |||
| const transition = { | |||
There was a problem hiding this comment.
Do we really need it to be an object now?
Johann-S
force-pushed
the
v4-johann-qunit-transition
branch
from
51fe56f to
6f9c3ff
Compare
|
Done @XhmikosR, plus I removed |
Johann-S
force-pushed
the
v4-johann-qunit-transition
branch
from
6f9c3ff to
fbb3214
Compare
|
I wonder, won't this break stuff for people using |
|
it can be a breaking change but if we let this method it will be the same as : supportsTransitionEnd() {
return true
}because we are compatible with browsers whose support transition end. |
|
Yeah, I think we should keep compatibility and add a todo comment that this should be removed in v5 |
Johann-S
force-pushed
the
v4-johann-qunit-transition
branch
from
fbb3214 to
f4dbc37
Compare
|
I did that 😉 |
|
Thanks! How about |
|
|
XhmikosR
approved these changes
Mar 20, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove that code because it's useless since we moved away from PhantomJS, plus by doing that our coverage increased a lot 😍