throw error when coverage is under our thresholds #25898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
approved these changes
Mar 20, 2018
XhmikosR
reviewed
Mar 20, 2018
| lines: 80, | ||
| branches: 80, | ||
| functions: 80 | ||
| statements: 89, |
There was a problem hiding this comment.
Are you sure about the new numbers? Maybe we should be less strict?
There was a problem hiding this comment.
For me it's pretty low we should be at least at 95% on those numbers
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that, we just had warnings, now it'll throw an error on Travis if our coverage is too low
/CC @XhmikosR @bardiharborow