Ship v4.1 #25972

mdo · 2018-03-29T15:57:56Z

Updates the docs directory from docs/4.0/ to docs/4.1/
Runs the build/ship.sh script to updated version from 4.0.0 to 4.1.0

We need to check some of this out though—I'm seeing some -webkit prefixes being dropped and I can't recall if those are intentional.

XhmikosR · 2018-03-29T20:30:35Z

@mdo: I pushed a patch to ignore vnu.jar's wrong language code warnings because we get false positives.

About the prefixes, https://github.com/browserslist/browserslist/blob/master/CHANGELOG.md#30

Regarding the rename, I don't think you should change the redirect_from parts. Unless this is intentional.

XhmikosR · 2018-03-29T20:37:47Z

docs/4.1/migration.md

@@ -319,7 +319,7 @@ Our documentation received an upgrade across the board as well. Here's the low d

 ### Responsive utilities

-All `@screen-` variables have been removed in v4.0.0. Use the `media-breakpoint-up()`, `media-breakpoint-down()`, or `media-breakpoint-only()` Sass mixins or the `$grid-breakpoints` Sass map instead.
+All `@screen-` variables have been removed in v4.1.0. Use the `media-breakpoint-up()`, `media-breakpoint-down()`, or `media-breakpoint-only()` Sass mixins or the `$grid-breakpoints` Sass map instead.


The migration file shouldn't have the versions changed.

razh · 2018-03-30T03:46:02Z

js/src/index.js

@@ -31,7 +31,7 @@ import Util from './util'
  const maxMajor = 4

  if (version[0] < ltMajor && version[1] < minMinor || version[0] === minMajor && version[1] === minMinor && version[2] < minPatch || version[0] >= maxMajor) {
-    throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.0.0')
+    throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.1.0')


This also doesn't need to be changed.

XhmikosR · 2018-03-30T07:48:08Z

@mdo: after you review let me know so that I rebase and clean up the branch before the final merge.

vsn4ik · 2018-03-29T21:52:29Z

js/src/index.js

@@ -31,7 +31,7 @@ import Util from './util'
  const maxMajor = 4

  if (version[0] < ltMajor && version[1] < minMinor || version[0] === minMajor && version[1] === minMinor && version[2] < minPatch || version[0] >= maxMajor) {
-    throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.0.0')
+    throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.1.0')


This is jQuery version, not Bootstrap.

XhmikosR · 2018-03-30T21:10:30Z

Obviously hence why I reverted it.

…

On Sat, Mar 31, 2018, 00:08 Vasilii Artemchuk ***@***.***> wrote: ***@***.**** approved this pull request. ------------------------------ In js/src/index.js <#25972 (comment)>: > @@ -31,7 +31,7 @@ import Util from './util' const maxMajor = 4 if (version[0] < ltMajor && version[1] < minMinor || version[0] === minMajor && version[1] === minMinor && version[2] < minPatch || version[0] >= maxMajor) { - throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.0.0') + throw new Error('Bootstrap\'s JavaScript requires at least jQuery v1.9.1 but less than v4.1.0') This is jQuery version, not Bootstrap. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#25972 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtX3kWguQtN0Bszs9Ng_7duqDK_JTks5tjp7egaJpZM4TAk-p> .

mdo · 2018-03-30T21:21:44Z

@XhmikosR Fwiw, I'm guessing @vsn4ik's comment was from looking at a different commit or not the full range of the diff. It's admittedly all too easy on GitHub to click into a notification and see a subset of the overall diff :).

fixed

XhmikosR · 2018-04-05T10:27:26Z

@mdo: when you are back to this,

git fetch --prune
git checkout ship-v4.1
git reset --hard

Then run the build script as normal. If you run the release-version script again, we'll need to review the changes again because it will change stuff that shouldn't change like in your first patch here.

mdo · 2018-04-08T21:24:20Z

New PR coming in #26218.

XhmikosR previously requested changes Mar 29, 2018

View reviewed changes

razh reviewed Mar 30, 2018

View reviewed changes

XhmikosR force-pushed the ship-v4.1 branch from f189419 to f6a8ced Compare March 30, 2018 07:41

vsn4ik approved these changes Mar 30, 2018

View reviewed changes

XhmikosR force-pushed the ship-v4.1 branch 2 times, most recently from ba95b06 to d6018b0 Compare April 2, 2018 16:24

XhmikosR force-pushed the ship-v4.1 branch 4 times, most recently from d9231f4 to f099c84 Compare April 5, 2018 10:24

mdo and others added 4 commits April 7, 2018 10:42

Update docs directory from docs/4.0/ to docs/4.1/

2931c1d

vnu.jar: Ignore all wrong language code warnings.

d4dd9c0

build script

f93f0f2

Revert unrelated version changes.

55b6f5e

XhmikosR force-pushed the ship-v4.1 branch from f099c84 to 55b6f5e Compare April 7, 2018 07:43

This was referenced Apr 8, 2018

vnu.jar: Ignore all wrong language code warnings. #26217

Merged

Ship v4.1.0 #26218

Merged

mdo closed this Apr 8, 2018

mdo deleted the ship-v4.1 branch April 8, 2018 21:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ship v4.1 #25972

Ship v4.1 #25972

mdo commented Mar 29, 2018

XhmikosR commented Mar 29, 2018 •

edited

Loading

XhmikosR Mar 29, 2018

razh Mar 30, 2018

XhmikosR commented Mar 30, 2018

vsn4ik Mar 29, 2018

XhmikosR commented Mar 30, 2018 via email

mdo commented Mar 30, 2018

XhmikosR commented Apr 5, 2018

mdo commented Apr 8, 2018

Ship v4.1 #25972

Ship v4.1 #25972

Conversation

mdo commented Mar 29, 2018

XhmikosR commented Mar 29, 2018 • edited Loading

XhmikosR Mar 29, 2018

Choose a reason for hiding this comment

razh Mar 30, 2018

Choose a reason for hiding this comment

XhmikosR commented Mar 30, 2018

vsn4ik Mar 29, 2018

Choose a reason for hiding this comment

XhmikosR commented Mar 30, 2018 via email

mdo commented Mar 30, 2018

XhmikosR commented Apr 5, 2018

mdo commented Apr 8, 2018

XhmikosR commented Mar 29, 2018 •

edited

Loading