Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carousel should not cycle when there is no data-ride on init #27968

Merged
merged 3 commits into from
Jan 4, 2019
Merged

carousel should not cycle when there is no data-ride on init #27968

merged 3 commits into from
Jan 4, 2019

Conversation

Johann-S
Copy link
Member

@Johann-S Johann-S commented Jan 3, 2019 •
edited
Loading

@Johann-S Johann-S requested a review from a team as a code owner January 3, 2019 21:18
@Johann-S Johann-S force-pushed the fix/cycle-when-no-data-ride branch from 568713e to 002e472 Compare January 3, 2019 21:31
@Johann-S Johann-S force-pushed the fix/cycle-when-no-data-ride branch from e344006 to e59fe57 Compare January 4, 2019 08:28
@mdo mdo mentioned this pull request Jan 4, 2019
Closed
@XhmikosR XhmikosR merged commit 89a73f1 into v4-dev Jan 4, 2019
@XhmikosR XhmikosR deleted the fix/cycle-when-no-data-ride branch January 4, 2019 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Johann-S @XhmikosR