Cleanup popover arrows #28008
Merged
Cleanup popover arrows #28008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would we want to wait on this for v5 since this breaks anything for folks who've customized Bootstrap's default popover template? I don't know how worth it is to do now for v4.3 knowing it could be funky for folks. At the very least, it changes where the arrows are generated and folks who remove them via CSS would have a breaking change for their upgrade path. |
|
Also, whenever we do want this to land, we can probably modify the JS to update that template to remove the extraneous |
|
@mdo Don't worry:wink: The CSS diffs are very simple. I don't think this will cause a breaking change. - .bs-popover-top > .arrow::before, .bs-popover-auto[x-placement^="top"] > .arrow::before,
- .bs-popover-top > .arrow::after,
- .bs-popover-auto[x-placement^="top"] > .arrow::after {
- border-width: 0.5rem 0.5rem 0;
- }
.bs-popover-top > .arrow::before, .bs-popover-auto[x-placement^="top"] > .arrow::before {
bottom: 0;
+ border-width: 0.5rem 0.5rem 0;
border-top-color: rgba(0, 0, 0, 0.25);
}
.bs-popover-top > .arrow::after, .bs-popover-auto[x-placement^="top"] > .arrow::after {
bottom: 1px;
+ border-width: 0.5rem 0.5rem 0;
border-top-color: #fff;
}x 4 directions |
|
it was my CSS sorry 😟 |
|
Hehe no problem, I got your back @Johann-S 😉 |
mdo
approved these changes
Jan 13, 2019
Closed
bkdotcom
added a commit
to bkdotcom/bootstrap
that referenced
this pull request
Jan 16, 2019
* v4-dev: (34 commits) tests: use jQuery from node_modules. (twbs#28059) Fix `js-main` script. (twbs#28057) Make progress animation respect `$enable-transitions` and `prefers-reduced-motion` media query Examples: add tabindex="-1" and aria-disabled="true" on disabled links Clean up .gitignore. (twbs#28050) Fix Carousel's touch option to not add touch listeners when set to false (twbs#28046) Remove map-merge (twbs#28033) Cleanup popover arrows (twbs#28008) Sync dropdown font size to base font size Sync dropdown font size with btn font size Remove background from nested tables Add some margin below the buttons Fix background size y Minify background property Combine background properties into one Prevent useless property rendering Don't render a background by default Prevent rendering of color property by default Change comment heading title to `Typography` (twbs#28032) Align toast variables (twbs#28041) ... # Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved and copied the
.arrow's pseudos sharedborder-width:to the pseudo elements themselves. This will generate 4 more properties (oh no 😱), but will remove 16 selectors of which 8 attribute selectors (woohoo! 🎉). As you can see, this made my day.I've also nested the pseudo's in the
scss.