Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative margin example #28140

Merged
merged 2 commits into from
Feb 3, 2019
Merged

Fix negative margin example #28140

merged 2 commits into from
Feb 3, 2019

Conversation

garhbod
Copy link
Contributor

@garhbod garhbod commented Jan 30, 2019

Negative margin example wasn't displaying correctly due to border and background styling being applied directly to the .col element. Made a child element and applied the styling to it

Original: https://getbootstrap.com/docs/4.2/utilities/spacing/#negative-margin
Demo: https://deploy-preview-28140--twbs-bootstrap4.netlify.com/docs/4.2/utilities/spacing/#negative-margin

Negative margin example wasn't displaying correctly due to border and background styling being applied directly to the `.col` element. Made a child element and applied the styling to it
Copy link
Member

@MartijnCuppens MartijnCuppens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks indeed better

@mdo mdo mentioned this pull request Feb 3, 2019
@XhmikosR XhmikosR merged commit 1275e35 into twbs:v4-dev Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants