add margin between consecutive fields with error #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, good catch, but instead of a new selector, I'm just going to ditch the -10px top margin I had in there. No reason for it anymore I think. That stuff is just too convoluted and needs revisiting in 2.0. Added this fix to the dev branch. Thanks! |
|
Cool - sounds good. Thanks for the update. |
DocX
pushed a commit
to DocX/bootstrap
that referenced
this pull request
Sep 16, 2014
Added kandan as an app that uses bootstrap-sass to the README.md
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When form fields appear consecutively with errors, there is no margin between them. This is caused by a negative top margin added to fields with error (to account for padding), but when they appear consecutively it causes the outer div.clearfix.error containers to touch up to one another with no margin. This fix adds back the margin on the subsequent consecutive fields. Similar to common "p + p" css margin fixes.