Docs: Use ESM Popper CDN reference in 'Using Bootstrap as a module' #38006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdo
approved these changes
Feb 6, 2023
Edit: done in twbs/examples#37 |
julien-deramond
commented
Feb 6, 2023
| @@ -82,6 +82,7 @@ params: | |||
| js_bundle_hash: "sha384-w76AqPfDkMBDXo30jS1Sgez6pr3x5MlQ1ZAGC+nuZB+EYdgRZgiwxhTBTkF7CXvN" | |||
| popper: "https://cdn.jsdelivr.net/npm/@popperjs/[email protected]/dist/umd/popper.min.js" | |||
| popper_hash: "sha384-oBqDVmMz9ATKxIep9tiCxS/Z9fNfEXiDAYTujMAeBAsjFuCZSmKbSSUnQlmh/jp3" | |||
| popper_esm: "https://cdn.jsdelivr.net/npm/@popperjs/[email protected]/dist/esm/popper.min.js" | |||
There was a problem hiding this comment.
@XhmikosR Is this solution OK for you as well? Or would you prefer another way by keeping only cdn.popper and to replace "umd" by "esm" on the fly thanks to a Hugo pipe or something where needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new
cdn.popper_esmconfig element used in "Using Bootstrap as a module" page to make this example works and consistent with https://github.com/twbs/examples/blob/main/sass-js-esm/index.html.Another way would be to keep
cdn.popperand to replaceumdbyesmon the fly thanks to a Hugo pipe or something.Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #37978