-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make modal windows scrollable #850
Conversation
looks good to me - thanks |
Can't this be also applied to 2.0-wip? |
it is in a branch i'm working on, but haven't pushed it yet. |
Anyway to swallow the scroll event for the body behind it? |
Twitter Bootstrap 2.0.1 (probably earlier versions too) inserts a body.modal-open {
overflow: hidden;
} I use this in my apps because I find it distracting when the body scrolls behind the backdrop. Scrolling is reinstated when the modal is dismissed. Hope this helps. |
@MeetDom Does this still work for you? I've tried your solution but it scrolls anyway. |
Yes definitely works for me in Safari Versions 5.1/5.2 and Chrome Version 19.0.1084.52 in Bootstrap 2.0.1/2.0.2. I haven't tried it in any other browsers or Bootstrap 2.0.3 yet. |
I'm hopeful this will be fixed in the next version of Bootstrap. See: twbs/bootstrap#849 and twbs/bootstrap#850
See #849 for details.
I put the output of
make
in a separate commit, in case you don't want to pull that.