Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 wip #864

Closed
wants to merge 1 commit into from
Closed

2.0 wip #864

wants to merge 1 commit into from

Conversation

JoyceBabu
Copy link
Contributor

Event.srcElement property does not work in Firefox. Replaced it with e.target, which is the recommended jQuery way.

@JoyceBabu
Copy link
Contributor Author

Should I submit such tiny changes as a pull request or a new issue?

@pokonski
Copy link
Contributor

It's a code change. I'd say PR is a good choice :)

@fat
Copy link
Member

fat commented Jan 2, 2012

target is not right. I'll think of a different way to do it.

@fat fat closed this Jan 2, 2012
@JoyceBabu
Copy link
Contributor Author

The current code doesn't work in firefox, whereas event.target works in all browsers. For IE and old versions of safari, jQuery store event.srcElement in the target property. ( https://github.com/jquery/jquery/blob/master/src/event.js#L539 )

If you were referring to the current approach with the comment "target is not right", please ignore the above comment :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants