Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorthands for transformations #892

Closed
wants to merge 1 commit into from
Closed

Add shorthands for transformations #892

wants to merge 1 commit into from

Conversation

jhuon
Copy link

@jhuon jhuon commented Jan 5, 2012

Hello,
I wrote some shorthands for CSS functions defining transformations.
I use it myself and I'm not sure if it's appropriated for Bootstrap but I just wanted to let you know.
It's my first fork and it's my first pull request, so I hope I'm doing it fine :)

@fat
Copy link
Member

fat commented Jan 5, 2012

this is very interesting - thanks for the pull request!

@mdo
Copy link
Member

mdo commented Jan 5, 2012

Indeed, looks like a powerful set of mixins! Will dig into these and see how we can best include them. It won't make it into master just yet—we're working on the 2.0-wip branch now and should have something released for that soon.

I'll leave this pull open for now and we can revisit it then to incorporate :).

@thomasfr
Copy link

thomasfr commented Jan 9, 2012

There is also a collection of cool CSS3 only animations available as animate.css : http://daneden.me/animate/
Maybe this could be added too?

@jhuon
Copy link
Author

jhuon commented Jan 9, 2012

Why not? Personally I like this kind of stuff :)
If you are interested, I also wrote some mixins for creating drop-shadow effects without image : https://github.com/jhuon/bootstrap/blob/shadows/lib/shadows.less

@thomasfr
Copy link

thomasfr commented Jan 9, 2012

@jhuon Nice. Thanks!

@mdo
Copy link
Member

mdo commented Jan 9, 2012

@thomasfr: Open a separate issue for the animate.css stuff, please, and I'll see where that fits in with our plans moving forward.

@jhuon: It's fine to do the advanced CSS3 stuff, but it doesn't feel like we're getting anything by falling back to something that works in fewer browsers than javascript. It's not likely that javascript is disabled as well.

@mdo mdo closed this Jan 9, 2012
@jhuon
Copy link
Author

jhuon commented Jan 10, 2012

@markdotto: You're absolutely right. Actually, I wrote this stuff basically for my needs, for testing purposes. This is clearly not something you want to use every day. But I had a dream that one day maybe, when all browsers will be fully CSS3 compliant, we'll get an easy to use animation framework from you guys! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants