Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracted color values out into theme.less #973

Closed
wants to merge 6 commits into from

Conversation

justindarc
Copy link

Pulled out "hardcoded" color values for items such as the topbar, success, warning, and danger classes into theme.less to simplify the customization of the default Bootstrap theme. Added a comment block above each color variable in theme.less to describe all of the UI elements that are affected by the value.

@mdo
Copy link
Member

mdo commented Jan 12, 2012

I appreciate the effort put into doing this, but I feel this particular implementation complicates this unnecessarily. It makes modifying variables look awfully intense with all the comments and adds another .less file to modify.

Also, we're not doing development on master anymore—all efforts on our end are towards 2.0.

@mdo mdo closed this Jan 12, 2012
@justindarc
Copy link
Author

No problem. I just figured I'd offer it up. I needed to be able to modify the color scheme on some of the elements that the variables.less file didn't allow you to modify (such as the topbar) so that was my main justification for doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants