Ignore defaultValue property in workspace:sync-metadata

twentyhq · Nov 22, 2024 · 028628c · 028628c
1 parent 74ba5e3
commit 028628c
Showing 1 changed file with 4 additions and 22 deletions.
diff --git a/...ngine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts b/...ngine/workspace-manager/workspace-sync-metadata/comparators/workspace-field.comparator.ts
@@ -8,10 +8,7 @@ import {
 } from 'src/engine/workspace-manager/workspace-sync-metadata/interfaces/comparator.interface';
 import { ComputedPartialFieldMetadata } from 'src/engine/workspace-manager/workspace-sync-metadata/interfaces/partial-field-metadata.interface';
 
-import {
-  FieldMetadataEntity,
-  FieldMetadataType,
-} from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
+import { FieldMetadataEntity } from 'src/engine/metadata-modules/field-metadata/field-metadata.entity';
 import { transformMetadataForComparison } from 'src/engine/workspace-manager/workspace-sync-metadata/comparators/utils/transform-metadata-for-comparison.util';
 
 const commonFieldPropertiesToIgnore = [
@@ -26,6 +23,7 @@ const commonFieldPropertiesToIgnore = [
   'gate',
   'asExpression',
   'generatedType',
+  'defaultValue',
 ];
 
 const fieldPropertiesToStringify = ['defaultValue'] as const;
@@ -57,19 +55,11 @@ export class WorkspaceFieldComparator {
     const originalFieldMetadataMap = transformMetadataForComparison(
       filteredOriginalFieldCollection,
       {
-        shouldIgnoreProperty: (property, originalMetadata) => {
+        shouldIgnoreProperty: (property) => {
           if (commonFieldPropertiesToIgnore.includes(property)) {
             return true;
           }
 
-          if (
-            originalMetadata &&
-            property === 'defaultValue' &&
-            originalMetadata.type === FieldMetadataType.SELECT
-          ) {
-            return true;
-          }
-
           return false;
         },
         propertiesToStringify: fieldPropertiesToStringify,
@@ -82,19 +72,11 @@ export class WorkspaceFieldComparator {
     const standardFieldMetadataMap = transformMetadataForComparison(
       standardFieldMetadataCollection,
       {
-        shouldIgnoreProperty: (property, originalMetadata) => {
+        shouldIgnoreProperty: (property) => {
           if (commonFieldPropertiesToIgnore.includes(property)) {
             return true;
           }
 
-          if (
-            originalMetadata &&
-            property === 'defaultValue' &&
-            originalMetadata.type === FieldMetadataType.SELECT
-          ) {
-            return true;
-          }
-
           return false;
         },
         propertiesToStringify: fieldPropertiesToStringify,