Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email invite design improvements #8681

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ehconitin
Copy link
Contributor

@ehconitin ehconitin commented Nov 22, 2024

closes #7140
image

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR enhances email invite design by improving layout compatibility across email clients and updating styling elements for better visual consistency.

  • Replaced flexbox with @react-email/components Row/Column structure in packages/twenty-emails/src/components/HighlightedContainer.tsx for better email client support
  • Added blue color (#5e90f2) to packages/twenty-emails/src/common-style.ts for consistent link styling
  • Updated company address and simplified Twenty's description in packages/twenty-emails/src/components/WhatIsTwenty.tsx
  • Added color prop to packages/twenty-emails/src/components/Link.tsx for flexible link styling
  • Removed unnecessary div wrapper in packages/twenty-emails/src/components/HighlightedText.tsx to fix display issues

6 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

} as React.CSSProperties;

export const HighlightedContainer = ({
children,
}: HighlightedContainerProps) => {
return (
<Container style={highlightedContainerStyle}>
<div style={divStyle}>{children}</div>
{React.Children.map(children, (child) => (
<Row>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Row component is missing a key prop for the mapped elements

Comment on lines 15 to 18
type HighlightedTextProps = {
value: ReactNode;
centered?: boolean;
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: The 'centered' prop is defined in the type but not used in the component implementation

} as React.CSSProperties;

export const HighlightedContainer = ({
children,
}: HighlightedContainerProps) => {
return (
<Container style={highlightedContainerStyle}>
<div style={divStyle}>{children}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a screenshot in your PR description? I just have the Logs testing (sure I could copy the html - is that what you were doing each time or you have something smarter?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! I did a simple Gmail SMTP configuration setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email invite design improvements
3 participants