Replace strtolower() with strtr() when dealing with method names #3237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
reviewed
Jan 8, 2020
|
|
nicolas-grekas
approved these changes
Jan 8, 2020
fabpot
approved these changes
Jan 8, 2020
fabpot
force-pushed
the
consistent-lowercase
branch
from
40bb530 to
30fedde
Compare
|
Thank you @mpdude. |
fabpot
added a commit
that referenced
this pull request
Jan 8, 2020
…names (mpdude) This PR was squashed before being merged into the 1.x branch (closes #3237). Discussion ---------- Replace strtolower() with strtr() when dealing with method names This is to improve consistency with the implementation of case-insensitivity for method names etc. in the Zend Engine: In fact, the ZE does not apply the internal `strtolower` implementation, but just maps ASCII `A-Z` to `a-z`. This was done in php/php-src@582514d to fix issues like https://bugs.php.net/bug.php?id=18556. Additionally, `strtok` might give a tiny (measurable?) performance gain over `strtolower`, plus it is not locale-dependant. Commits ------- 30fedde Replace strtolower() with strtr() when dealing with method names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to improve consistency with the implementation of case-insensitivity for method names etc. in the Zend Engine: In fact, the ZE does not apply the internal
strtolowerimplementation, but just maps ASCIIA-Ztoa-z.This was done in php/php-src@582514d to fix issues like https://bugs.php.net/bug.php?id=18556.
Additionally,
strtokmight give a tiny (measurable?) performance gain overstrtolower, plus it is not locale-dependant.