Migrate NodeTestCase to static data providers #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 3, 2024
derrabus
force-pushed
the
improvement/node-test-case-static-data-provider
branch
2 times, most recently
from
bc0333f to
741002d
Compare
derrabus
force-pushed
the
improvement/node-test-case-static-data-provider
branch
from
741002d to
d7cfa76
Compare
derrabus
force-pushed
the
improvement/node-test-case-static-data-provider
branch
from
d7cfa76 to
f555a33
Compare
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 11 requires data providers to be static. This PR prepares our abstract
NodeTestCaseby deprecating the non-staticgetTests()and adding a staticprovideTests()as a replacement. I've also added PHPUnit attributes which newer PHPUnit releases prefer over PHPDoc annotations.