npm start requires Admin privileges

[dkundel]

As raised in #7, currently the symlinking process of placing index.html into the public/ folder requires Admin privileges on Windows.

This is not ideal. This file should not be modified and ideally be connected to the flex-plugin dependency. Since the current build script is based on react-scripts which enforces the presence of public/index.html, we need to have it present. An alternative solution is to force copy the file in on every npm start.

[andreasonny83]

According to this nodejs/node-v0.x-archive#8936, the symlinkSync doc is wrong as it's defining the parameters in the wrong order.

I didn't manage to test that on a Windows machine but my suggestion is to replace
fs.symlinkSync(indexHtmlSource, indexHtmlTarget);
with
fs.symlinkSync(indexHtmlTarget, indexHtmlSource);
in packages/react-app-rewire-flex-plugin/lib/index.js

[dkundel]

Those seem to be old pre 1.0 docs of Node. It might actually be a legacy Node.js issue. @viperguynaz is running 8.12 which shouldn't have this issue: nodejs/node#18518

My guess is that npm creates the node_modules folder with some other permissions. I don't have a Windows machine around right now but I'll try to see if I can get someone to repro it for me.