VideoProcessors v3.0 #2053
Merged
VideoProcessors v3.0 #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…streams where supported.
* Support outputFrameBufferContextType=bitmaprenderer.
* Pass unit tests.
docs: introduce beta support for Video Processor V3
manjeshbhargav
commented
Dec 6, 2024
tsdef/VideoProcessor.d.ts
Outdated
| @@ -1,6 +1,33 @@ | |||
| /** | |||
| * @beta VideoFrame is part of Video Processor V3 support which is currently in beta. | |||
There was a problem hiding this comment.
Remove beta tag
There was a problem hiding this comment.
These APIs are used by other developers apart from Video Processors SDK, so let's remove references to the video processors sdk.
tsdef/VideoProcessor.d.ts
Outdated
|
|
||
| /** | ||
| * A processor for manipulating video frames. | ||
| * @beta Video Processor V3 support is currently in beta. |
There was a problem hiding this comment.
Remove beta tag
There was a problem hiding this comment.
These APIs are used by other developers apart from Video Processors SDK, so let's remove references to the video processors sdk.
tsdef/VideoProcessor.d.ts
Outdated
| * - VideoFrame (beta) | ||
| * @param outputFrameBuffer The output frame buffer. The context type can be: | ||
| * - '2d' (default) | ||
| * - 'bitmaprenderer' (beta, Chromium-based browsers only) |
There was a problem hiding this comment.
Remove the text in brackets
tsdef/types.d.ts
Outdated
| inputFrameBufferType?: 'video' | 'canvas' | 'offscreencanvas'; | ||
| /** | ||
| * The type of input frame buffer to use. | ||
| * @beta The 'videoframe' value is currently in beta and only supported on browsers that support VideoFrame API |
tsdef/types.d.ts
Outdated
|
|
||
| /** | ||
| * The type of context to use for the output frame buffer. | ||
| * @beta The 'bitmaprenderer' value is currently in beta. It is only supported on Chromium-based browsers, and falls back to '2d' on other browsers. |
luisrivas
approved these changes
Dec 9, 2024
luisrivas
added a commit
that referenced
this pull request
Dec 18, 2024
* Refactor video frame capture logic to its own module. * Use insertable streams where supported. * Support inputFrameBufferType=videoframe. * Support outputFrameBufferContextType=bitmaprenderer. * Support outputFrameBufferContextType=bitmaprenderer only for chrome. * Work around: markdown-it/linkify-it#111 * VBLOCKS-3643 VBLOCKS-3644 * docs: introduce beta support for Video Processor V3 --------- Co-authored-by: Manjesh Malavalli <[email protected]> Co-authored-by: twilio-ci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio
Pull Request Details
Description
A description of what this PR does.
Burndown
Before review
npm test