-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix missing id on hypetrain eventsub #208
Conversation
bors r+ |
208: fix missing id on hypetrain eventsub r=Emilgardis a=Emilgardis Co-authored-by: Emil Gardström <[email protected]>
2227abe
to
0a8b44b
Compare
Canceled. |
bors r+ |
208: fix missing id on hypetrain eventsub r=Emilgardis a=Emilgardis Co-authored-by: Emil Gardström <[email protected]>
Build failed: |
ICE D:
this seems wierd, I can replicate myself, but can't replicate with another library/crate, trying to find the cause to file an issue (if applicable) edit: probably some wierd state I have, going to try and find out where it is, features ftw :D |
found it. rust-lang/rust#88600 |
tried to fix it with something like this // Custom default trait because I don't want to make T a real Default.
trait CustomDefault {
fn custom_default() -> Self;
}
impl CustomDefault for HypeTrainCooldownExpiration{
fn custom_default() -> Self {
HypeTrainCooldownExpiration { }
}
}
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
#[cfg_attr(feature = "deny_unknown_fields", serde(deny_unknown_fields))]
#[non_exhaustive]
pub struct HypeTrainCooldownExpiration {}
#[derive(Deserialize)]
pub enum HypeTrainEventsV1Reply {
#[serde(default = "CustomDefault::custom_default", "rename = "hype-train-cooldown-expiration")]
HypeTrainCooldownExpiration(HypeTrainCooldownExpiration),
} but that doesn't work. serde-rs/serde#2088 While waiting for a fix in rustdoc, I'll make the field not hidden and make it use a real struct for content and wrap it with an option, in case there ever will be content attached to the event. |
bors r+ |
No description provided.