Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use substring instead of startsWith for punycode check #244

Merged
merged 1 commit into from
Jan 23, 2018
Merged

Use substring instead of startsWith for punycode check #244

merged 1 commit into from
Jan 23, 2018

Conversation

kaushlakers
Copy link
Contributor

@kaushlakers kaushlakers commented Jan 23, 2018 •
edited
Loading

startsWith needs a polyfill on older browsers. We don't really need it as substring works fine. Links #242.

@kaushlakers kaushlakers merged commit b77fabf into twitter:master Jan 23, 2018
This was referenced Jan 26, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leeaustinadams leeaustinadams leeaustinadams approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaushlakers @leeaustinadams