Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.gitignore): Ignore virtualenv directories #32

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

tony
Copy link
Contributor

@tony tony commented Jul 12, 2022

Will you accept this, (or any variation of this pattern)?

This way contributors won't be prompted to stage .venv, .env, etc. virtual environment dirs.

Here's what I've used on another project for a while

@tony
Copy link
Contributor Author

tony commented Jul 12, 2022

@Thisch Thoughts on this? This makes it a lot easier to contribute for those that don't have a global gitignore file.

If it impedes I can close for now

@twmr
Copy link
Owner

twmr commented Jul 12, 2022

I do use a global .gitignore for the projects I'm working on to avoid that I have to create .gitignore PRs for upstream repos. Anyway, if this helps contributors - LGTM.

@twmr twmr merged commit 7eb7c6a into twmr:master Jul 12, 2022
@tony tony deleted the ignore-venv branch July 12, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants