Adds note on using with next/image component #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikaelbr Thanks for updating the readme file! I think I should check |
|
FYI, I also posted this PR that should help with potential issues regarding this: vercel/next.js#18326 |
|
@mikaelbr Cool, thanks 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the package. Use it a lot and love it for creating semantically grouped resources in feature folders!
Today Vercel announced Next.js 10.0.0. In 10.0.0 you have the
next/imagecomponent which optimizes images either through servers, external loaders, or Vercel. In any case, it seems to work withnext-imagesand resolving images not placed inpublic/folder. However, obviously, it doesn't play well with Data URLs and thus there can be some issues with the default value of inline images with this package. Also, I think much of the cases where Data URLs are handy can be optimized better with coachable generated webp files. So this PR adds a note on using withnext/imagecomponent and recommends deactivating inline images entirely when doing so.