fix(eslint-plugin): [no-unnecessary-template-expression] allow interp…

…olating type parameter in type context (#10739) * fix(eslint-plugin): [no-unnecessary-template-expression] allow type parameter * update
typescript-eslint · Feb 3, 2025 · 77df70d · 77df70d
1 parent 8376abe
commit 77df70d
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 22 deletions.
diff --git a/packages/eslint-plugin/docs/rules/no-unnecessary-template-expression.mdx b/packages/eslint-plugin/docs/rules/no-unnecessary-template-expression.mdx
@@ -67,6 +67,9 @@ enum ABC {
 }
 type ABCUnion = `${ABC}`;
 
+// Interpolating type parameters is allowed.
+type TextUtil<T extends string> = `${T}`;
+
 const stringWithNumber = `1 + 1 = 2`;
 
 const stringWithBoolean = `true is true`;

diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-template-expression.ts b/packages/eslint-plugin/src/rules/no-unnecessary-template-expression.ts
@@ -451,13 +451,14 @@ export default createRule<[], MessageId>({
           isTrivialInterpolation(node) &&
           !hasCommentsBetweenQuasi(node.quasis[0], node.quasis[1])
         ) {
-          const { constraintType } = getConstraintInfo(
+          const { constraintType, isTypeParameter } = getConstraintInfo(
             checker,
             services.getTypeAtLocation(node.types[0]),
           );
 
           if (
             constraintType &&
+            !isTypeParameter &&
             isUnderlyingTypeString(constraintType) &&
             !isEnumType(constraintType)
           ) {

diff --git a/.../eslint-plugin/tests/docs-eslint-output-snapshots/no-unnecessary-template-expression.shot b/.../eslint-plugin/tests/docs-eslint-output-snapshots/no-unnecessary-template-expression.shot
diff --git a/packages/eslint-plugin/tests/rules/no-unnecessary-template-expression.test.ts b/packages/eslint-plugin/tests/rules/no-unnecessary-template-expression.test.ts
@@ -1190,6 +1190,12 @@ enum Foo {
 }
 type Bar = \`\${Foo.A}\`;
     `,
+    `
+function foo<T extends string>() {
+  const a: \`\${T}\` = 'a';
+}
+    `,
+    'type T<A extends string> = `${A}`;',
   ],
 
   invalid: [
@@ -1431,26 +1437,5 @@ enum Foo {
 type Bar = Foo.A;
       `,
     },
-    {
-      code: `
-function foo<T extends string>() {
-  const a: \`\${T}\` = 'a';
-}
-      `,
-      errors: [
-        {
-          column: 13,
-          endColumn: 17,
-          endLine: 3,
-          line: 3,
-          messageId: 'noUnnecessaryTemplateExpression',
-        },
-      ],
-      output: `
-function foo<T extends string>() {
-  const a: T = 'a';
-}
-      `,
-    },
   ],
 });