fix(utils): add to JSONSchema4Type missing Array and Object

[wespickett]

Updates type to add missing Array and Object

From https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/json-schema/index.d.ts#L30

PR Checklist

• Addresses an existing open issue: fixes #000
• That issue was marked as accepting prs
• Steps in Contributing were taken

Overview

[typescript-eslint]

Thanks for the PR, @wespickett!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

[netlify]

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	06bbd87
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/64d3ae446b9a1c0008aaa104
😎 Deploy Preview	https://deploy-preview-7406--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 06bbd87. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 37 targets

• nx build website
• nx test eslint-plugin --coverage=false
• Node 20 - nx test visitor-keys
• nx run types:build
• Node 20 - nx run types:build
• nx test eslint-plugin-tslint --coverage=false
• nx test eslint-plugin-internal --coverage=false
• Node 20 - nx test parser
• nx test typescript-estree --coverage=false
• Node 20 - nx test scope-manager
• Node 20 - nx test rule-schema-to-typescript-types
• Node 20 - nx test type-utils
• Node 20 - nx test eslint-plugin-internal
• Node 20 - nx test utils
• Node 20 - nx test repo-tools
• Node 20 - nx test typescript-estree
• Node 20 - nx test eslint-plugin-tslint
• Node 20 - nx test eslint-plugin
• nx run-many --target=typecheck --parallel
• Node 16 - nx test scope-manager --coverage=false
• Node 16 - nx run types:build
• Node 16 - nx test eslint-plugin-tslint --coverage=false
• Node 20 - nx test ast-spec
• nx run-many --target=lint --parallel
• Node 16 - nx test rule-schema-to-typescript-types --coverage=false
• Node 16 - nx test typescript-estree --coverage=false
• Node 16 - nx test eslint-plugin-internal --coverage=false
• Node 16 - nx test repo-tools --coverage=false
• nx run eslint-plugin:generate:configs
• Node 16 - nx test eslint-plugin --coverage=false
• Node 16 - nx test visitor-keys --coverage=false
• nx run integration-tests:test
• Node 16 - nx test utils --coverage=false
• Node 16 - nx test parser --coverage=false
• Node 16 - nx test type-utils --coverage=false
• Node 16 - nx test ast-spec --coverage=false
• nx run-many --target=build --parallel --exclude=website --exclude=website-eslint

---

Sent with 💌 from NxCloud.

[bradzacher]

As per our contributing guide please file an issue first so that we can discuss the change and the usecases you're intending to target with it.

Closing pending discussion.

[bradzacher]

I don't think it is the best thing for us to add this here because JSONSchema4Type is used in the enum property where arrays and objects are disallowed (slash non-sensical).

So I think it makes sense for us to define a new type JSONSchema4DefaultValue which includes all of the valid default values.

[wespickett]

@bradzacher Updated with a separate type named JSONSchema4TypeExtended, which I thought could be a better name, but can change it to JSONSchema4DefaultValue if needed

[bradzacher]

Spelling is hard 😅
Technically this is a breaking change but given it's a cock up I'm fine with doing this here. Given nobody noticed I doubt anyone is using it directly yet!

[bradzacher]

I'll leave this as a future exercise - but we can go one step further with this and narrow the default prop for each type. Eg a boolean type schema can only have a boolean default, and an array type schema can only have an array.

Thanks for fixing this!