Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use list-available command to query available log sources #143

Open
danepowell opened this issue Mar 30, 2022 · 1 comment
Open

Use list-available command to query available log sources #143

danepowell opened this issue Mar 30, 2022 · 1 comment

Comments

@danepowell
Copy link
Collaborator

Right now the list of available log sources to filter is hardcoded:

'Log types to stream',

This isn't very future-proof in case log sources change. Additionally, it's possible that not all servers support all log sources.

The logstream API supports a list-available command that could be used to get available log sources instead: https://github.com/acquia/logstream#list-available-inbound

@typhonius
Copy link
Owner

I had a play with this today and it doesn't do what we expect it to do. It only works once stream-environment has run for a little bit and connected all the servers up. This is also a pain as you're in an event loop and don't know when to trigger it to close because you're awaiting messages from an unknown number of servers and log files.

If you run list-available in any other context, it only provides the logstream server as available. There might be another hidden websocket server command that can do what we want, but I think the easiest way would be to query the main API itself for logs and then use that as part of a list command:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants