Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-713: Fixes #875: Apache access logstream failing #876

Merged
merged 3 commits into from
Apr 8, 2022

Conversation

danepowell
Copy link
Contributor

@danepowell danepowell commented Mar 30, 2022

Motivation

Fixes #875

It turns out other logs (mysql slow query, for instance) were borked as well, and some (balancer request) were missing entirely.

Proposed changes
Depends on typhonius/acquia-logstream#144
Use the available types provided by typhonius/acquia-logstream.
This drastically speeds up the command (by cutting out an API call) and makes it more reliable (since it turns out the API was lying to us 😄 )

Alternatives considered

typhonius/acquia-logstream#143

Testing steps

  1. Follow the contribution guide to set up your development environment.
  2. Clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. acli app:log:tail

Merge requirements

  • Bug, enhancement, or breaking change label applied
  • Manual testing by a reviewer

@danepowell danepowell added the bug Something isn't working label Mar 30, 2022
@danepowell danepowell marked this pull request as draft March 30, 2022 21:30
@danepowell danepowell requested a review from grasmash April 4, 2022 15:40
@danepowell
Copy link
Contributor Author

@grasmash can you review this and the upstream PR? typhonius/acquia-logstream#144

This won't pass tests until the upstream PR is merged and a new release cut.

@danepowell danepowell marked this pull request as ready for review April 4, 2022 15:42
@grasmash
Copy link
Contributor

grasmash commented Apr 8, 2022

You could patch it it the mean time.

@grasmash
Copy link
Contributor

grasmash commented Apr 8, 2022

#898 updates typhonius/acquia-logstream

@grasmash
Copy link
Contributor

grasmash commented Apr 8, 2022

Rebased and pushed after merging #898

@grasmash grasmash merged commit c58e59e into acquia:master Apr 8, 2022
@danepowell danepowell deleted the CLI-713 branch July 21, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI-713: Apache access logstream failing
2 participants