Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is codesniffer a require and not a dev require? #61

Closed
generalredneck opened this issue Apr 18, 2020 · 1 comment
Closed

Why is codesniffer a require and not a dev require? #61

generalredneck opened this issue Apr 18, 2020 · 1 comment

Comments

@generalredneck
Copy link

I've been trying to use cgr to install acquia_cli, but my version of phpcbf and phpcs keeps getting clobbered by the version this library is using. I don't think Acquia requires you to use codesniffer to use it, so I would suggest moving it if possible.
typhonius added a commit that referenced this issue Apr 20, 2020
@typhonius
Fixes #61: Move phpcs to require-dev.
8baa588
@typhonius
Copy link
Owner

Thanks for this - totally an oversight as it should only be a dev dependency!

@grasmash grasmash mentioned this issue Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change specs grasmash/acquia-php-sdk-v2
2 participants
@generalredneck @typhonius