Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User agents are applied multiple times #87

Closed
typhonius opened this issue Oct 6, 2020 · 0 comments
Closed

User agents are applied multiple times #87

typhonius opened this issue Oct 6, 2020 · 0 comments
Labels
bug

Comments

@typhonius
Copy link
Owner

Describe the bug
User agent strings are applied multiple times because the addOption keeps applying them on subsequent queries.

To Reproduce
Steps to reproduce the behavior including calling code:

  1. Run the db:backup:list command using Acquia Cli
  2. Dump the user agent headers
  3. See a string containing multiple instances of each user agent

Expected behavior
A single user agent string for each library in use.
@typhonius typhonius mentioned this issue Oct 6, 2020
Closed
typhonius added a commit that referenced this issue Oct 6, 2020
@typhonius
Fixes #87 and ensures that user agents are only added once per unique…
440a824 
… string.
@typhonius typhonius added the bug label Oct 6, 2020
typhonius added a commit that referenced this issue Oct 6, 2020
@typhonius
Fixes #87 and ensures that user agents are only added once per unique…
78b0106 
… string.
typhonius added a commit that referenced this issue Oct 6, 2020
@typhonius
Fixes #87 and ensures that user agents are only added once per unique…
e2e522d 
… string.
typhonius added a commit that referenced this issue Oct 6, 2020
@typhonius
Fixes #87 and ensures that user agents are only added once per unique…
4c6dbc9 
… string.
@grasmash grasmash mentioned this issue Jun 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change specs grasmash/acquia-php-sdk-v2
1 participant
@typhonius