Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription models #193

Merged
merged 2 commits into from
Oct 1, 2021
Merged

Conversation

eporama
Copy link
Contributor

@eporama eporama commented Sep 2, 2021

In looking briefly at #192 I realize that we didn't have a basic model for Subscriptions which need a number of items and endpoints embellished, but this at least gets the basic object in place.

@codecov
Copy link

codecov bot commented Sep 2, 2021

Codecov Report

Merging #193 (713b6da) into master (a4d3597) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master      #193   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       245       250    +5     
===========================================
  Files             85        88    +3     
  Lines           1219      1254   +35     
===========================================
+ Hits            1219      1254   +35     
Impacted Files Coverage Δ
src/Endpoints/Subscriptions.php 100.00% <100.00%> (ø)
src/Response/SubscriptionResponse.php 100.00% <100.00%> (ø)
src/Response/SubscriptionsResponse.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4d3597...713b6da. Read the comment docs.

@danepowell danepowell changed the title Initial commit with basic Subscription models Add subscription models Oct 1, 2021
@danepowell danepowell merged commit 48ca8aa into typhonius:master Oct 1, 2021
@danepowell
Copy link
Collaborator

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants