CLI-1026: Catch malformed responses #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing a lot of errors like
property_exists(): Argument #1 ($object_or_class) must be of type object|string, null givenin Client::processResponse(). This occurs when the body of the response is empty. Logs indicate the API returning 200 for these requests.The only way I could imagine this happening is if the API is returning a truly empty response. Since it's returning a 200 response, it can't be caught as a BadResponseException in Client::makeRequest(), and any other type of connection error (i.e., connection reset) should generate an exception prior to the typeerror being thrown (barring a bug like guzzle/guzzle#2203).
Anyway, checking for an empty body and logging additional details about the request will help diagnose this. Since this is basically debugging code, I'm not trying to make it pretty. If it's going to be permanent, the exception should probably be its own class.