Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding leave and change-owner to organizations #84

Merged
merged 4 commits into from
Sep 15, 2020

Conversation

eporama
Copy link
Contributor

@eporama eporama commented Sep 13, 2020

I also changed the comment to use the consistent American spelling of organization since all of the methods and classes use that…

Not sure what tests need to be added as methods such as deleteMember don't seem to be tested either.

Also, the $options is marked as json assuming that #82 is merged… otherwise we should revert it to form_params

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 98.128% when pulling 7733a74 on eporama:enhance_organizations into 28e88b5 on typhonius:master.

@coveralls
Copy link

coveralls commented Sep 13, 2020

Coverage Status

Coverage increased (+0.009%) to 99.077% when pulling dc0e124 on eporama:enhance_organizations into 4451a51 on typhonius:master.

@typhonius
Copy link
Owner

Not sure what tests need to be added as methods such as deleteMember don't seem to be tested either.

I’ve generally tried to keep the API calling methods of this library 100% tested so we don’t fall behind on testing as new methods are added. What has happened though is that as the library has grown, I’ve noticed that the tests probably aren’t in the most optimal places within the repo.

public function testMemberDelete()

@eporama eporama force-pushed the enhance_organizations branch from 22ea881 to 6a0cd69 Compare September 13, 2020 23:30
@eporama
Copy link
Contributor Author

eporama commented Sep 13, 2020

Not sure why it's still down, I added tests for the two methods… but .003% ? Maybe I need to add some tests for the Connector as well? ;-)

@typhonius typhonius merged commit 3377127 into typhonius:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants