Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong example of deploy:prepare #51

Closed
andrebonon opened this issue Mar 24, 2020 · 2 comments
Closed

Wrong example of deploy:prepare #51

andrebonon opened this issue Mar 24, 2020 · 2 comments
Labels

Comments

@andrebonon
Copy link

andrebonon commented Mar 24, 2020

Describe the bug

Wrong execution when calling acquiacli deploy:prepare.
On the example section on Readme file, it says acquiacli deploy:prepare UUID, environmentFrom, environmentTo

# Copy the files and db from alpha to dev for testing new code
acquiacli deploy:prepare prod:myacquiasite alpha dev

but looking deeply on DeployCommand.php it is public function deployPrepare($uuid, $environmentTo, $environmentFrom = null).

Expected behavior

I believe the expected behavior must be:

# Copy the files and db to dev from alpha for testing new code.
acquiacli deploy:prepare prod:myacquiasite **dev alpha** 

Also, it could be more clear regarding not passing the last argument, which means that it is going to pull the db and files from production.

Additional context
Tested on acquia_cli:2.0.3 tag.

Thanks for this very helpful project.

@typhonius
Copy link
Owner

Thank you for this report. Would it make sense to have a confirm action in there which prompts the user to agree to the deploy task and to explicitly state the from and the to?

@typhonius
Copy link
Owner

I'm going to split this into two issues. The bug in the documentation as part of this ticket is seen to in #52

If you would like a confirm action, I'd see that as new functionality so could you please make a feature request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants