Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a test for the lock and skip lock functionality. #64

Merged
merged 2 commits into from
Apr 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 29 additions & 23 deletions src/Cli/AcquiaCli.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@
namespace AcquiaCli\Cli;

use Robo\Robo;
use Robo\Common\ConfigAwareTrait;
use Symfony\Component\Console\Command\LockableTrait;
use Robo\Runner as RoboRunner;
use Robo\Application;
use Symfony\Component\Console\Input\InputInterface;
use Robo\Runner as RoboRunner;
use Robo\Common\ConfigAwareTrait;
use AcquiaCloudApi\Connector\Client;
use AcquiaLogstream\LogstreamManager;
use AcquiaCli\Injector\AcquiaCliInjector;
use Symfony\Component\Console\Input\ArgvInput;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Command\LockableTrait;
use Symfony\Component\Console\Output\OutputInterface;
use Consolidation\AnnotatedCommand\CommandFileDiscovery;
use AcquiaCloudApi\Connector\Client;
use AcquiaCli\Injector\AcquiaCliInjector;
use AcquiaCli\Cli\CloudApi;
use AcquiaLogstream\LogstreamManager;

/**
* Class AcquiaCli
Expand Down Expand Up @@ -75,6 +75,12 @@ public function __construct(
InputOption::VALUE_NONE,
'Automatically respond "yes" to all confirmation questions.'
),
new InputOption(
'--no-lock',
null,
InputOption::VALUE_NONE,
'Run commands without locking. Allows multiple instances of commands to run concurrently.'
),
new InputOption(
'--limit',
'-l',
Expand Down Expand Up @@ -138,27 +144,27 @@ public function injectParameters($container)
$parameterInjection = $container->get('parameterInjection');
$parameterInjection->register('AcquiaCli\Cli\CloudApi', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCli\Cli\Config', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Connector\Client', new AcquiaCliInjector());
$parameterInjection->register('AcquiaLogstream\LogstreamManager', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Connector\Client', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Account', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Applications', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Environments', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Databases', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Servers', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Domains', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Code', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\DatabaseBackups', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Crons', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Account', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Roles', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Permissions', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Teams', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Variables', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Logs', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Notifications', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\DatabaseBackups', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Databases', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Domains', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Environments', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Insights', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\LogForwardingDestinations', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\SslCertificates', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Logs', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Notifications', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Organizations', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Permissions', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Roles', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Servers', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\SslCertificates', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Teams', new AcquiaCliInjector());
$parameterInjection->register('AcquiaCloudApi\Endpoints\Variables', new AcquiaCliInjector());
}

/**
Expand All @@ -169,7 +175,7 @@ public function injectParameters($container)
public function run(InputInterface $input, OutputInterface $output)
{
// Obtain a lock and exit if the command is already running.
if (!$this->lock('acquia-cli-command')) {
if (!$input->hasParameterOption('--no-lock') && !$this->lock('acquia-cli-command')) {
$output->writeln('The command is already running in another process.');

return 0;
Expand Down
2 changes: 1 addition & 1 deletion src/Cli/CloudApi.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

namespace AcquiaCli\Cli;

use Robo\Config\Config;
use AcquiaCloudApi\Connector\Client;
use AcquiaCloudApi\Connector\Connector;
use AcquiaCloudApi\Endpoints\Applications;
use AcquiaCloudApi\Endpoints\Environments;
use AcquiaCloudApi\Endpoints\Organizations;
use AcquiaCloudApi\Response\EnvironmentResponse;
use AcquiaCloudApi\Response\OrganizationResponse;
use Robo\Config\Config;
use Symfony\Component\Console\Input\InputInterface;

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Cli/Config.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
namespace AcquiaCli\Cli;

use Robo\Config\Config as RoboConfig;
use Robo\Config\GlobalOptionDefaultValuesInterface;
use Consolidation\Config\Loader\ConfigProcessor;
use Consolidation\Config\Loader\YamlConfigLoader;
use Robo\Config\GlobalOptionDefaultValuesInterface;

/**
* Class Config
Expand Down
1 change: 0 additions & 1 deletion src/Commands/AcquiaCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,6 @@ public function validateApiOptionsHook(CommandData $commandData)
*/
public function initUuidHook(InputInterface $input, AnnotationData $annotationData)
{

if ($input->hasArgument('uuid')) {
$uuid = $input->getArgument('uuid');

Expand Down
20 changes: 20 additions & 0 deletions tests/AcquiaCliApplicationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,12 @@
use AcquiaCli\Cli\AcquiaCli;
use Symfony\Component\Console\Output\BufferedOutput;
use Symfony\Component\Stopwatch\Stopwatch;
use Symfony\Component\Console\Command\LockableTrait;

class AcquiaCliApplicationTest extends AcquiaCliTestCase
{
use LockableTrait;

private $root;

public function setUp()
Expand Down Expand Up @@ -49,6 +52,23 @@ public function testVersion()
$this->assertContains('AcquiaCli 2', $actualValue);
}

public function testLock()
{
// Obtain an identical lock and then attempt to run acquiacli.
$this->lock('acquia-cli-command');
$command = ['--version'];
$actualValue = $this->execute($command);
$this->assertContains('The command is already running in another process.', $actualValue);

// Use --no-lock to override the lock.
$command[] = '--no-lock';
$actualValue = $this->execute($command);
$this->assertContains('AcquiaCli', $actualValue);

// Unlock to ensure tests are able to continue.
$this->release();
}

public function testClientOptions()
{
$command = ['application:list', '--sort=label', '--filter=label=@*sample*', '--limit=2'];
Expand Down