Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-paginate UI bug with temporary workaround #584

Merged
merged 139 commits into from
Mar 25, 2024
Merged

Conversation

mpark63
Copy link
Collaborator

@mpark63 mpark63 commented Mar 25, 2024

See:
AdeleD/react-paginate#501

I modified next config, hopefully that doesn't cause other issues.

D3Rkness and others added 30 commits March 9, 2023 00:04
#445)

* DEV-116 fix lowest credit requirement for intersession/summer semester

* DEV-116 formatted with prettier

* DEV-116 default color of summer semester to be green (as long as #credits < 14)

* DEV-116: Run Prettier on all problematic files

* DEV-116 Merge dev branch to branch 116 the run Prettier

* DEV-116 Uninstall node/package-lock and then run prettier
DEV-158: Add loading logo to cart search in tracker
IN-49: add meta tags to landing page for SEO
commit 1c20e10
Author: Josephine Deng <[email protected]>
Date:   Sat Apr 8 09:31:15 2023 -0400

    DEV-188 deleting last comment in thread deletes that thread

commit 63aada4
Merge: 0ec1971 2ebd274
Author: Jiarui Chen <[email protected]>
Date:   Tue Apr 4 21:37:15 2023 -0400

    Merge pull request #477 from uCredit-Dev/DEV-158

    DEV-158: Add loading logo to cart search in tracker

commit 0ec1971
Author: QifanSun1128 <[email protected]>
Date:   Sun Apr 2 17:07:51 2023 -0400

    DEV-116 fix lowest credit requirement for intersession/summer semester (#445)

    * DEV-116 fix lowest credit requirement for intersession/summer semester

    * DEV-116 formatted with prettier

    * DEV-116 default color of summer semester to be green (as long as #credits < 14)

    * DEV-116: Run Prettier on all problematic files

    * DEV-116 Merge dev branch to branch 116 the run Prettier

    * DEV-116 Uninstall node/package-lock and then run prettier

commit 2ebd274
Author: jchen324 <[email protected]>
Date:   Sat Apr 1 19:29:35 2023 -0400

    DEV-158 Add loading logo to cart search in tracker
dependabot bot and others added 25 commits September 25, 2023 03:17
Bumps [@svgr/webpack](https://github.com/gregberge/svgr) from 6.5.1 to 8.1.0.
- [Release notes](https://github.com/gregberge/svgr/releases)
- [Changelog](https://github.com/gregberge/svgr/blob/main/CHANGELOG.md)
- [Commits](gregberge/svgr@v6.5.1...v8.1.0)

---
updated-dependencies:
- dependency-name: "@svgr/webpack"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 8.10.0 to 9.0.0.
- [Changelog](https://github.com/prettier/eslint-config-prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/eslint-config-prettier@v8.10.0...v9.0.0)

---
updated-dependencies:
- dependency-name: eslint-config-prettier
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [md-editor-rt](https://github.com/imzbf/md-editor-rt) from 2.11.3 to 4.7.0.
- [Release notes](https://github.com/imzbf/md-editor-rt/releases)
- [Commits](imzbf/md-editor-rt@v2.11.3...v4.7.0)

---
updated-dependencies:
- dependency-name: md-editor-rt
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…lopment/mini-css-extract-plugin-2.7.6

Bump mini-css-extract-plugin from 2.7.2 to 2.7.6
…lopment/md-editor-rt-4.7.0

Bump md-editor-rt from 2.11.3 to 4.7.0
…lopment/eslint-config-prettier-9.0.0

Bump eslint-config-prettier from 8.10.0 to 9.0.0
…lopment/svgr/webpack-8.1.0

Bump @svgr/webpack from 6.5.1 to 8.1.0
* fix prereq display not updating if course not in cache

* update prereq display: run prettier

* update-prereq-display: address eslint issue maybe

* update-prereq-display: remove unused import

* update-prereq-display: run prettier again

* update-prereq-display: same fix for postreqs

* Fix console log errors

* run prettier

* fix eslint errors

---------

Co-authored-by: mpark63 <[email protected]>
* bug fixes for post reqs and console errors in dev

* minor UI change

* run prettier
* chore: update team page

* merge dev into prod (#499)

* DEV-146 delete comments when delete plan

* IN-49: add meta tags to landing page for SEO

* DEV-146 in progress

* DEV-146 in progress

* DEV-146 fix issue with year settings dropdown not opening

* feat: filter workd :)

* fix: run prettier

* DEV-123 Remove all code commented out related to roadmap

* DEV-123 Delete Roadmap folder

* DEV-123 Remove all related code to roadmap, including mode.roadmap

* DEV-146 deleting year deletes comments on tthat year, its semesters, and its courses

* DEV-146 delete comments on course when course is deleted

* DEV-158 Add loading logo to cart search in tracker

* DEV-123 remove Preview.tsx

* DEV-123 Run prettier

* DEV-123 add back eslint comment code

* DEV-116 fix lowest credit requirement for intersession/summer semester (#445)

* DEV-116 fix lowest credit requirement for intersession/summer semester

* DEV-116 formatted with prettier

* DEV-116 default color of summer semester to be green (as long as #credits < 14)

* DEV-116: Run Prettier on all problematic files

* DEV-116 Merge dev branch to branch 116 the run Prettier

* DEV-116 Uninstall node/package-lock and then run prettier

* DEV-123 reorder eslint comment to bottom

* comments on semesters no longer  make years scrollable

* Fix Issue with fine requirements not turning green after being fulfilled

* DEV-146 simplify deleting comment threads for deletecoursepopup and deleteyearpopup

* DEV-157 Prevent users from duplicating courses through drag and drop

* DEV-146 simplify deleting thread for deleteplanpopup

* Squashed commit of the following:

commit 1c20e10
Author: Josephine Deng <[email protected]>
Date:   Sat Apr 8 09:31:15 2023 -0400

    DEV-188 deleting last comment in thread deletes that thread

commit 63aada4
Merge: 0ec1971 2ebd274
Author: Jiarui Chen <[email protected]>
Date:   Tue Apr 4 21:37:15 2023 -0400

    Merge pull request #477 from uCredit-Dev/DEV-158

    DEV-158: Add loading logo to cart search in tracker

commit 0ec1971
Author: QifanSun1128 <[email protected]>
Date:   Sun Apr 2 17:07:51 2023 -0400

    DEV-116 fix lowest credit requirement for intersession/summer semester (#445)

    * DEV-116 fix lowest credit requirement for intersession/summer semester

    * DEV-116 formatted with prettier

    * DEV-116 default color of summer semester to be green (as long as #credits < 14)

    * DEV-116: Run Prettier on all problematic files

    * DEV-116 Merge dev branch to branch 116 the run Prettier

    * DEV-116 Uninstall node/package-lock and then run prettier

commit 2ebd274
Author: jchen324 <[email protected]>
Date:   Sat Apr 1 19:29:35 2023 -0400

    DEV-158 Add loading logo to cart search in tracker

* DEV-123 Add back comments unrelated to roadmap

* DEV-193 Enable API call when search filters are changed

* DEV-192 Fix crashing of plan import

* DEV-170 Fix Nish's Image name

* DEV-170: Fix Nish's Picture

* DEV-193 Fetch all courses when the user first opens the search modal

* Update teamList.ts

* DEV-148 and DEV-154 fix issue with comments overview commenters header bar appearing/not appearing unexpectedly

* DEV-148 and DEV-154 fix issue with 'looks like there's no comment yet' not appearing after deleting last comment

* Removed todo comment for filter by upper levels

* DEV-123 try to pass prettier

* IN-70 hopefully differentiate tracking dev vs jhu users in amplitude (#488)

* Implemented filter by recently updated for reviewee search

* Removed TODO comment

* Ran prettier

* Individual plans are also sorted by recently updated

* Revert "Merge branch 'DEV-146' into DEV-148"

This reverts commit 6d32d98, reversing
changes made to dc612fb.

* Removed unnecesary else statement

* DEV-190: Create CIS Minor (#492)

* Update BA Chemistry Major

* run prettier

* add general KSAS requirements for BA Chem

* update chem criteria

* Fix advanced elective courses bugs

* run prettier

* implement CIS minor

* fix minor errors and formatting

---------

Co-authored-by: mpark63 <[email protected]>

* DEV-188 deleting last comment in thread deletes that thread (#489)

* DEV-170 fix nish's picture on team page

* DEV-56 fix default major issue when changing between plans, adding/deleting majors, or adding/deleting the courses (#490)

* DEV-56 fix default major issue when adding/deleting the courses

* DEV-56 Fix default major issue when adding/deleting a major

---------

Co-authored-by: mpark63 <[email protected]>
Co-authored-by: Rosa <[email protected]>
Co-authored-by: QifanSun1128 <[email protected]>
Co-authored-by: jchen324 <[email protected]>
Co-authored-by: QifanSun1128 <[email protected]>
Co-authored-by: Jiarui Chen <[email protected]>
Co-authored-by: nishikarp <[email protected]>
Co-authored-by: Aryaman Shodhan <[email protected]>
Co-authored-by: Minseo Park <[email protected]>
Co-authored-by: nishikar12 <[email protected]>
Co-authored-by: nishikarp <[email protected]>
Co-authored-by: Jonathan He <[email protected]>
Co-authored-by: ml <[email protected]>
Co-authored-by: Rosa <[email protected]>

* add back chem

* remove lint errs

---------

Co-authored-by: ml <[email protected]>
Co-authored-by: uCredit-Dev <[email protected]>
Co-authored-by: ml <[email protected]>
Co-authored-by: Josephine Deng <[email protected]>
Co-authored-by: Rosa <[email protected]>
Co-authored-by: QifanSun1128 <[email protected]>
Co-authored-by: jchen324 <[email protected]>
Co-authored-by: QifanSun1128 <[email protected]>
Co-authored-by: Jiarui Chen <[email protected]>
Co-authored-by: nishikarp <[email protected]>
Co-authored-by: Aryaman Shodhan <[email protected]>
Co-authored-by: nishikar12 <[email protected]>
Co-authored-by: nishikarp <[email protected]>
Co-authored-by: Jonathan He <[email protected]>
Co-authored-by: Rosa <[email protected]>
* chore: update team page

* merge dev into prod (#499)

* DEV-146 delete comments when delete plan

* IN-49: add meta tags to landing page for SEO

* DEV-146 in progress

* DEV-146 in progress

* DEV-146 fix issue with year settings dropdown not opening

* feat: filter workd :)

* fix: run prettier

* DEV-123 Remove all code commented out related to roadmap

* DEV-123 Delete Roadmap folder

* DEV-123 Remove all related code to roadmap, including mode.roadmap

* DEV-146 deleting year deletes comments on tthat year, its semesters, and its courses

* DEV-146 delete comments on course when course is deleted

* DEV-158 Add loading logo to cart search in tracker

* DEV-123 remove Preview.tsx

* DEV-123 Run prettier

* DEV-123 add back eslint comment code

* DEV-116 fix lowest credit requirement for intersession/summer semester (#445)

* DEV-116 fix lowest credit requirement for intersession/summer semester

* DEV-116 formatted with prettier

* DEV-116 default color of summer semester to be green (as long as #credits < 14)

* DEV-116: Run Prettier on all problematic files

* DEV-116 Merge dev branch to branch 116 the run Prettier

* DEV-116 Uninstall node/package-lock and then run prettier

* DEV-123 reorder eslint comment to bottom

* comments on semesters no longer  make years scrollable

* Fix Issue with fine requirements not turning green after being fulfilled

* DEV-146 simplify deleting comment threads for deletecoursepopup and deleteyearpopup

* DEV-157 Prevent users from duplicating courses through drag and drop

* DEV-146 simplify deleting thread for deleteplanpopup

* Squashed commit of the following:

commit 1c20e10
Author: Josephine Deng <[email protected]>
Date:   Sat Apr 8 09:31:15 2023 -0400

    DEV-188 deleting last comment in thread deletes that thread

commit 63aada4
Merge: 0ec1971 2ebd274
Author: Jiarui Chen <[email protected]>
Date:   Tue Apr 4 21:37:15 2023 -0400

    Merge pull request #477 from uCredit-Dev/DEV-158

    DEV-158: Add loading logo to cart search in tracker

commit 0ec1971
Author: QifanSun1128 <[email protected]>
Date:   Sun Apr 2 17:07:51 2023 -0400

    DEV-116 fix lowest credit requirement for intersession/summer semester (#445)

    * DEV-116 fix lowest credit requirement for intersession/summer semester

    * DEV-116 formatted with prettier

    * DEV-116 default color of summer semester to be green (as long as #credits < 14)

    * DEV-116: Run Prettier on all problematic files

    * DEV-116 Merge dev branch to branch 116 the run Prettier

    * DEV-116 Uninstall node/package-lock and then run prettier

commit 2ebd274
Author: jchen324 <[email protected]>
Date:   Sat Apr 1 19:29:35 2023 -0400

    DEV-158 Add loading logo to cart search in tracker

* DEV-123 Add back comments unrelated to roadmap

* DEV-193 Enable API call when search filters are changed

* DEV-192 Fix crashing of plan import

* DEV-170 Fix Nish's Image name

* DEV-170: Fix Nish's Picture

* DEV-193 Fetch all courses when the user first opens the search modal

* Update teamList.ts

* DEV-148 and DEV-154 fix issue with comments overview commenters header bar appearing/not appearing unexpectedly

* DEV-148 and DEV-154 fix issue with 'looks like there's no comment yet' not appearing after deleting last comment

* Removed todo comment for filter by upper levels

* DEV-123 try to pass prettier

* IN-70 hopefully differentiate tracking dev vs jhu users in amplitude (#488)

* Implemented filter by recently updated for reviewee search

* Removed TODO comment

* Ran prettier

* Individual plans are also sorted by recently updated

* Revert "Merge branch 'DEV-146' into DEV-148"

This reverts commit 6d32d98, reversing
changes made to dc612fb.

* Removed unnecesary else statement

* DEV-190: Create CIS Minor (#492)

* Update BA Chemistry Major

* run prettier

* add general KSAS requirements for BA Chem

* update chem criteria

* Fix advanced elective courses bugs

* run prettier

* implement CIS minor

* fix minor errors and formatting

---------

Co-authored-by: mpark63 <[email protected]>

* DEV-188 deleting last comment in thread deletes that thread (#489)

* DEV-170 fix nish's picture on team page

* DEV-56 fix default major issue when changing between plans, adding/deleting majors, or adding/deleting the courses (#490)

* DEV-56 fix default major issue when adding/deleting the courses

* DEV-56 Fix default major issue when adding/deleting a major

---------

Co-authored-by: mpark63 <[email protected]>
Co-authored-by: Rosa <[email protected]>
Co-authored-by: QifanSun1128 <[email protected]>
Co-authored-by: jchen324 <[email protected]>
Co-authored-by: QifanSun1128 <[email protected]>
Co-authored-by: Jiarui Chen <[email protected]>
Co-authored-by: nishikarp <[email protected]>
Co-authored-by: Aryaman Shodhan <[email protected]>
Co-authored-by: Minseo Park <[email protected]>
Co-authored-by: nishikar12 <[email protected]>
Co-authored-by: nishikarp <[email protected]>
Co-authored-by: Jonathan He <[email protected]>
Co-authored-by: ml <[email protected]>
Co-authored-by: Rosa <[email protected]>

---------

Co-authored-by: ml <[email protected]>
Co-authored-by: Minseo Park <[email protected]>
Co-authored-by: uCredit-Dev <[email protected]>
Co-authored-by: ml <[email protected]>
Co-authored-by: Josephine Deng <[email protected]>
Co-authored-by: mpark63 <[email protected]>
Co-authored-by: Rosa <[email protected]>
Co-authored-by: QifanSun1128 <[email protected]>
Co-authored-by: jchen324 <[email protected]>
Co-authored-by: QifanSun1128 <[email protected]>
Co-authored-by: Jiarui Chen <[email protected]>
Co-authored-by: nishikarp <[email protected]>
Co-authored-by: Aryaman Shodhan <[email protected]>
Co-authored-by: nishikarp <[email protected]>
Co-authored-by: Jonathan He <[email protected]>
Co-authored-by: Rosa <[email protected]>
* placeholder add/update course buttons

* update 'update course' button ui

* save progress kewk

* completed share/export plan redesign

* hopefully resolve eslint errors

* run prettier

* pls eslint pls

* prettier pls
* added input output of file

* Switch to exceljs and refine excel export

* Printed most info

* Add semester number calculation to excel sheet

* added blob

* major export

* we're donnneeeeeeeeeeee

* Ran prettier

* Remove unused majorworksheetconstants.ts file

* fix eslint issues

* Fix eslint errors

* run prettier again

* debugged export feature

* returned console.logs

* fixed eslint issues

---------

Co-authored-by: D3Rkness <[email protected]>
Co-authored-by: mpark63 <[email protected]>
* Add final popup; TODO: add demo link

* final-popup: added link, updated message, and ran prettier
Copy link

vercel bot commented Mar 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ucredit-frontend-typescript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 25, 2024 9:33pm
ucredit-frontend-typescript-local ✅ Ready (Inspect) Visit Preview Mar 25, 2024 9:33pm

Copy link
Owner

@uCredit-Dev uCredit-Dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why the finalpopup pages appear here again

@mpark63 mpark63 merged commit 13fc7ce into master Mar 25, 2024
13 of 15 checks passed
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.