Expose parse_os, parse_device and parse_ua #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are actually public in the uap-java library too https://github.com/ua-parser/uap-java/blob/master/src/main/java/ua_parser/Parser.java#L89-L99 |
opti
requested changes
Apr 7, 2023
|
@opti, I have addressed your feedback. Thank you |
opti
approved these changes
Apr 13, 2023
|
Thank you @daniel-statsig, new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I only care about individual parts of the UserAgent. I am looking for performance gains and noticed that multiple regexes are done and the results are not being used.
If it is possible, would you mind exposes these functions as public?
My code that uses the parser is here (https://github.com/statsig-io/ruby-sdk/blob/main/lib/evaluator.rb#L453-L461). I hope this better illustrates what I am attempting to do.