Add library model for Apache Commons CollectionUtils.isNotEmpty (#932)

[pochopsp]

Thank you for contributing to NullAway!

Please note that once you click "Create Pull Request" you will be asked to sign our Uber Contributor License Agreement via CLA assistant.

Before pressing the "Create Pull Request" button, please provide the following:

• Added library model for Apache Commons CollectionUtils.isNotEmpty

• related to issue Support org.apache.commons.lang3.StringUtils.isNotEmpty #932

• void apacheCollectionsCollectionUtilsIsNotEmpty() and void apacheCollections4CollectionUtilsIsNotEmpty() tests have been added to FrameworkTests.java

[CLAassistant]

All committers have signed the CLA.

[msridhar]

@pochopsp thanks for the contribution! #932 was originally written for StringUtils.isNotEmpty. Any chance you could extend this PR to handle that method, so we can close out that issue?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.61%. Comparing base (d6b7fa3) to head (49d5cb5).
Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1062      +/-   ##
============================================
+ Coverage     87.60%   87.61%   +0.01%     
  Complexity     2203     2203              
============================================
  Files            85       85              
  Lines          7187     7193       +6     
  Branches       1415     1415              
============================================
+ Hits           6296     6302       +6     
  Misses          456      456              
  Partials        435      435              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pochopsp]

Hi @msridhar , thanks for your kind reply. If I got it right, org.apache.commons.lang.StringUtils and org.apache.commons.lang3.StringUtils are respectively handled at line 754 and 756 here: https://github.com/uber/NullAway/blob/49d5cb54364cbb5e6f521e770026e9e25b2203e7/nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java (they were already there before my commit)
Maybe I could add two unit tests for them?

[msridhar]

You're right! The issue was not renamed properly. I'll go ahead and merge this one, thanks!