Skip to content
This repository has been archived by the owner on Mar 4, 2022. It is now read-only.

Add walk-timeout command line flag #545

Merged
merged 6 commits into from
Mar 31, 2020
Merged

Add walk-timeout command line flag #545

merged 6 commits into from
Mar 31, 2020

Conversation

smaye81
Copy link
Contributor

@smaye81 smaye81 commented Mar 26, 2020

Adds a walk-timeout flag to certain commands that involve walking the directory structure.

If no walk-timeout is specified where applicable, 3 seconds (3s) will be used as the default which is the current default. Therefore, this maintains backwards compatibility with current walk timeout and allows users to override at a command-level.

Fixes #516

@smaye81 smaye81 requested a review from smallsamantha March 26, 2020 17:45
@codecov
Copy link

codecov bot commented Mar 26, 2020

Codecov Report

Merging #545 into dev will increase coverage by 0.16%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #545      +/-   ##
==========================================
+ Coverage   66.09%   66.26%   +0.16%     
==========================================
  Files         144      144              
  Lines        7462     7490      +28     
==========================================
+ Hits         4932     4963      +31     
+ Misses       2023     2019       -4     
- Partials      507      508       +1     
Impacted Files Coverage Δ
internal/file/file.go 100.00% <ø> (+10.00%) ⬆️
internal/cmd/templates.go 84.08% <90.90%> (+0.48%) ⬆️
internal/cmd/flags.go 100.00% <100.00%> (ø)
internal/exec/exec.go 73.52% <100.00%> (+2.56%) ⬆️
internal/exec/runner.go 53.25% <100.00%> (+0.05%) ⬆️
internal/file/proto_set_provider.go 69.94% <100.00%> (+1.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd23eea...b78e68c. Read the comment docs.

@smaye81 smaye81 requested a review from osawill March 27, 2020 14:11
Copy link

@smallsamantha smallsamantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

niiice

@smaye81 smaye81 merged commit 45aa5ef into dev Mar 31, 2020
@smaye81 smaye81 deleted the walk_timeout_flag branch March 31, 2020 13:57
judezhu pushed a commit to dapperlabs/prototool that referenced this pull request Aug 27, 2021
* Adds walk timeout to command line flag to commands which walk the directory structure.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

can we change the walktimeout ?
2 participants