Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add openrazer-daemon #1402

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dreamyukii
Copy link
Contributor

this pr will add openrazer-daemon to Bluefin and Aurora
i have 2 reason for adding this package
1.Making easier for Razer peripheral users to configure their device since bluefin and aurora already including openrazer-kmod by default.
2. Configuration tools is available on flathub like Razer Genie.

Copy link
Contributor

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too much bloat for the base image. I don't own any Razer things. I don't see why the user cannot overlay the package.

Maybe try to add it to the more gamer-oriented Bazzite images?

@dreamyukii
Copy link
Contributor Author

That's too much bloat for the base image. I don't own any Razer things. I don't see why the user cannot overlay the package.

Maybe try to add it to the more gamer-oriented Bazzite images?

the problem with layering is that you need to remove the repo when upgrading to new version then re-add the repo since every Fedora version it will use different repo version.
Also bazzite already decided to make just recipe for layering openrazer-daemon.

@storopoli
Copy link
Contributor

Also bazzite already decided to make just recipe for layering openrazer-daemon.

And why not proposing this same approach here?
A just recipe would not bloat the base image with things that a tiny minority of users need.

@dreamyukii
Copy link
Contributor Author

Also bazzite already decided to make just recipe for layering openrazer-daemon.

And why not proposing this same approach here? A just recipe would not bloat the base image with things that a tiny minority of users need.

i prefer this approach compared to layering, its the same as adding libratbagd daemon but for razer devices.
also it only add like 3-4 more rpm package since the rest of openrazer-daemon dependencies is already included

@castrojo
Copy link
Member

Not sure on this one still, let's see what others think.

@m2Giles
Copy link
Member

m2Giles commented Jun 23, 2024

I think we should remove libratbagd. We probably should clean up old dependencies

Question, what does this daemon provide? Can this be run in a container?

@castrojo
Copy link
Member

I think it's vestigial and solaar replaces it? @KyleGospo would know.

@m2Giles
Copy link
Member

m2Giles commented Jun 23, 2024

Yeah we also have vestigial stuff for the pano extension. We never ended up shipping it.

@dreamyukii
Copy link
Contributor Author

I think we should remove libratbagd. We probably should clean up old dependencies

Question, what does this daemon provide? Can this be run in a container?

it's the same as libratbagd but for Razer devices, i tried to run this daemon with rootful distrobox but it failed to run

@dreamyukii dreamyukii closed this Aug 11, 2024
@dreamyukii dreamyukii deleted the add-openrazer-daemon branch August 11, 2024 09:07
@dreamyukii dreamyukii restored the add-openrazer-daemon branch August 11, 2024 09:07
@dreamyukii dreamyukii reopened this Aug 11, 2024
@m2Giles
Copy link
Member

m2Giles commented Nov 10, 2024

We are removing the open Razer KMod because the mod pulls in Akmods as a whole (we do not need to include all srpm stuff on the image).

I'm very mixed on if we should have this kmod on the image especially if we do not include the userspace components.

@dreamyukii
Copy link
Contributor Author

I think removing hardware support and tell users to create custom image because their keyboard/mouse from Razer cannot be configured is not a good experience.

@m2Giles
Copy link
Member

m2Giles commented Nov 11, 2024

I placed the kmod back in for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants