Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(just): clean up ujust recipes to fit newer style #1914

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tulilirockz
Copy link
Collaborator

Should fix #1805

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 10, 2024
@m2Giles
Copy link
Member

m2Giles commented Nov 10, 2024

We should also use this as an opportunity to clean up stale ones.

just/bluefin-system.just Outdated Show resolved Hide resolved
just/bluefin-system.just Outdated Show resolved Hide resolved
just/bluefin-system.just Outdated Show resolved Hide resolved
@m2Giles
Copy link
Member

m2Giles commented Nov 10, 2024

when working with the justfiles. Please be sure to run just fix. We run just check as part of the workflow to make sure we don't ship broken justfiles.

@tulilirockz tulilirockz force-pushed the switch-channels branch 2 times, most recently from d51c42e to 3d7f301 Compare November 10, 2024 15:43
@tulilirockz tulilirockz changed the title chore(just): make aliases into recipes to get autocompletion chore(just): clean up ujust recipes to fit newer style Nov 13, 2024
@tulilirockz tulilirockz marked this pull request as draft November 13, 2024 04:28
@tulilirockz
Copy link
Collaborator Author

Should I also include a move to bootc on this PR? I am thinking about refactoring most of these scripts to not use rpm-ostree and instead use a wrapper over bootc that allows it to run rootless (ubootc or something)

@tulilirockz
Copy link
Collaborator Author

The indentation on some places also seems a bit funky, ill be reformatting them to always fit 4 spaces indentation

@castrojo
Copy link
Member

Should I also include a move to bootc on this PR?

Follow on PRs are always better instead of conflating things.

a wrapper over bootc that allows it to run rootless (ubootc or something)

This is out of scope for us, we're trying to delete as much of our custom stuff as possible these days.

just/bluefin-system.just Outdated Show resolved Hide resolved
@tulilirockz
Copy link
Collaborator Author

Now the idea was to remove a few old ones, like the pytorch, gnome-vrr, (...) - Anyone has any guesses what to remove? Ill make a little list that i feel that could be deleted

@tulilirockz
Copy link
Collaborator Author

Then we could regroup stuff, honestly I feel like separating it in apps, tools and system doesnt seem like the best? apps and tools could be the same category (tools)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ujust switch-channel alias is broken
3 participants