-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] PAM: Build GDM support only on the library #566
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
+ Coverage 83.77% 84.11% +0.34%
==========================================
Files 80 82 +2
Lines 7098 7077 -21
Branches 75 75
==========================================
+ Hits 5946 5953 +7
+ Misses 820 791 -29
- Partials 332 333 +1 ☔ View full report in Codecov by Sentry. |
521bae5
to
6702205
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This will allow us to make it optional in next steps
We don't really use all the gdm-related code in the PAM Exec child that we use in normal PAM transactions, so no need to compile it at all by default while we need it in the PAM library that GDM will consume.
6702205
to
9e353f0
Compare
I've made the integration tests to require the gdm tag now and added to debian side too |
There's quite a bit of code that is GDM related that we don't really need to include into the compiled PAM binary that we use for authentication in non-GDM cases.
We don't really use all the gdm-related code in the PAM Exec child that
we use in normal PAM transactions, so no need to compile it at all by
default while we need it in the PAM library that GDM will consume.
This is basically the opposite of #292, as that tried to unify the logic while here we assumed that we're going to ship two different implementations, and so reducing the logic in one side when is not needed.